Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

新規にフォローした人のwithRepliesをtrueにする機能を追加 #12048

Merged
merged 29 commits into from
Oct 17, 2023
Merged

新規にフォローした人のwithRepliesをtrueにする機能を追加 #12048

merged 29 commits into from
Oct 17, 2023

Conversation

anatawa12
Copy link
Member

What

新規にフォローした人のwithRepliesをtrueにする機能を追加する

Why

解決したい問題は #12009 や #12006 と同様にすべてのユーザについてwithRepliesをオンにするのが著しく面倒なことで、このPullReqではこの問題を新規にフォローする人について解決します。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (9338ab4) 79.26% compared to head (148beb6) 79.39%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #12048      +/-   ##
===========================================
+ Coverage    79.26%   79.39%   +0.12%     
===========================================
  Files          930      931       +1     
  Lines        99219    99364     +145     
  Branches      8065     8088      +23     
===========================================
+ Hits         78646    78889     +243     
+ Misses       20573    20475      -98
Files Coverage Δ
packages/backend/src/core/UserFollowingService.ts 74.64% <100.00%> (+0.43%) ⬆️
packages/backend/src/models/FollowRequest.ts 100.00% <100.00%> (ø)
...c/queue/processors/RelationshipProcessorService.ts 88.46% <100.00%> (+0.62%) ⬆️
...ckend/src/server/api/endpoints/following/create.ts 98.43% <100.00%> (+0.01%) ⬆️
...ackages/frontend/src/components/MkFollowButton.vue 100.00% <100.00%> (ø)
...ges/backend/src/core/activitypub/ApInboxService.ts 18.75% <0.00%> (ø)
...end/src/server/api/endpoints/i/import-following.ts 82.55% <50.00%> (+0.20%) ⬆️
packages/frontend/src/pages/user/home.vue 90.97% <66.66%> (+0.01%) ⬆️
packages/backend/src/core/QueueService.ts 50.99% <66.66%> (-0.01%) ⬇️
...ueue/processors/ImportFollowingProcessorService.ts 42.71% <0.00%> (ø)
... and 1 more

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

anatawa12
anatawa12 commented Oct 16, 2023
View reviewed changes
locales/ja-JP.yml Outdated Show resolved Hide resolved
@syuilo
Copy link
Member

syuilo commented Oct 16, 2023 •
edited
Loading

where: 'account'としてクライアントで設定を持っておいて、following/create時にwithRepliesを設定するようにした方がスマートかも

@anatawa12

This comment was marked as resolved.

Sign in to view
@anatawa12
Copy link
Member Author

あとはフォローインポートでサーバーに情報ほしいと思う

@syuilo
Copy link
Member

syuilo commented Oct 16, 2023

今度は端末ごとの設定忘れするのでwithreplies関連情報サーバで持っててほしい

where: 'account' であればサーバーに保存される

@syuilo
Copy link
Member

syuilo commented Oct 16, 2023

あとはフォローインポートでサーバーに情報ほしいと思う

ふーむ

@anatawa12
Copy link
Member Author

where: 'account' であればサーバーに保存される

なるほどです。これは勘違いしてました。

@anatawa12 anatawa12 force-pushed the with-replies-for-newly-followed-users branch from db92f2c to 8054ce9 Compare October 16, 2023 06:18
syuilo
syuilo reviewed Oct 16, 2023
View reviewed changes
packages/frontend/src/pages/settings/general.vue Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

クライアント設定の中にあるのは違うかも(他に良い場所は思いつかないけど)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

若干違和感はありますが元々のshowPreviewを一応参考にしました

syuilo
syuilo reviewed Oct 16, 2023
View reviewed changes
locales/ja-JP.yml Outdated Show resolved Hide resolved
@syuilo
Copy link
Member

syuilo commented Oct 16, 2023 •
edited
Loading

where: 'account'としてクライアントで設定を持っておいて、following/create時にwithRepliesを設定するようにした方がスマートかも

＋ フォローインポート時にwithReplies: trueとしてインポートするかどうか設定可能にする

というやり方もありそうと思った

@anatawa12
Copy link
Member Author

たしかにそっちに選択があってもいいですね。その方針にしてみます

@anatawa12
Copy link
Member Author

importは試せてないですが普通のフォローボタンは動作確認までしました

@anatawa12
Copy link
Member Author

importもどうさかくにんしました。

@syuilo
Copy link
Member

syuilo commented Oct 16, 2023

frontendのlintの問題が直ればあとはYOSASOU

@anatawa12
Copy link
Member Author

lint、どう処理するのが正しいですかね

@anatawa12
Copy link
Member Author

lintは通るようになりましたがe2eが落ちてる...

@anatawa12
Copy link
Member Author

frontend e2eは 491a832 で落ちてなくて 148beb6 で落ちてるって感じなのですがスタイル変更しかしてないのでランダムで落ちたりしますか？

@syuilo
Copy link
Member

syuilo commented Oct 17, 2023

e2eが落ちてるのは関係なさそう

@syuilo syuilo merged commit 5a3c657 into misskey-dev:develop Oct 17, 2023
14 of 15 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 17, 2023

👍🏻 👍🏻 👍🏻

@anatawa12 anatawa12 deleted the with-replies-for-newly-followed-users branch October 17, 2023 14:08
@anatawa12 anatawa12 mentioned this pull request Dec 14, 2023
Open
@Sayamame-beans Sayamame-beans mentioned this pull request Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syuilo syuilo syuilo left review comments

Assignees
No one assigned
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anatawa12 @syuilo @Sayamame-beans